AGI: Refactor PictureMgr
, support early KQ1 pics, fix Troll fill
#6388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
PictureMgr
subclasses to separate PreAGI code from AGIPictureMgr
subclassPictureMgr
and friendsAt some point this was about adding Apple II picture cropping. Detours were made.
While testing, I saw that the Troll from Troll's Tale was missing flood fills in some rooms, so that got reversed and bundled in. It was a good test of the new structure.
To my knowledge, this is the first public implementation of the "Game Adaptation Langage" picture format from early KQ1. I reverse engineered it last month and developed the renderer in my tools, so porting it over was another good test. Although this KQ1 code isn't directly usable (yet??) I patched scummvm to display all the pictures for screenshots and they look good. We are nowhere near supporting these KQ1 versions of course, but now there's one less obstacle.
Show thy face, Troll
Show thy shirt, Troll
Screenshots of futures past