Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRAPHICS: Fix potential bug in drawThickLine2 #6393

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

ccawley2011
Copy link
Member

This was encountered during the development of PR #6374 where the loop iterator wasn't being used and each point was being plotted in the same place.

The function is only used in the SCI engine, but I'm not sure which games use it and where.

@sluicebox
Copy link
Member

I don't think any supported SCI games use this.

The only calls to GfxPaint32::makeLineBitmap with a potential thickness > 1 are kernel functions kAddLine and kUpdateLine. I searched my script repo for all calls to these two, and there are very few. Only two games pass a thickness > 1.

One is Torin, which passes 2 on the chapter selection screen, but GfxPaint32::makeLineBitmap rounds 2 down to 1.

The other is Hoyle5, it passes a thickness of 7 in its SpeakWindow class, but the class is not used in the CD versions, and those are all we support. Maybe it's used in the floppy versions, but we will never support them because they don't contain menu resources.

@bluegr
Copy link
Member

bluegr commented Jan 6, 2025

Thanks! I've fixed the conflict via the github UI. Squashing

@bluegr bluegr merged commit cd77a78 into scummvm:master Jan 6, 2025
8 checks passed
@ccawley2011 ccawley2011 deleted the drawthickline2-bug branch January 6, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants