MEDIASTATION: Make use of simpleBlitFrom #6394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on what is implemented thus far in this engine, this looks fine. I appreciate the improvement! |
npjg
approved these changes
Jan 8, 2025
|
For merging this, is the correct merge option "Squash and merge" or "Rebase and merge"? For a PR with 1 commit, does it really matter? Is there a preference in this case? |
|
Thanks @npjg! In most cases, we rebase and merge. The only case where we squash is when we want to avoid polluting history with unneeded commits, or we want to fix commit messages in PRs that only have a single commit with a wrong message. In this case, we can just merge. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be straight forward since the engine exclusively uses paletted surfaces and doesn't seem to need scaling or palette remapping, but I haven't been able to test it.