GRAPHICS: MACGUI: Make it possible to disable menus #6395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2025 17:34
Disabled menus can still be opened. Menu items in disabled menus will look and act as if they were individually disabled. Enabling the menu will restore it to its pre-disabled state.
|
Nice work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a real Macintosh, you can disable entire menus. They will show up as grayed out in the menu bar, everything in them will be grayed out, and you cannot open submenus. As seen in this screenshot from an emulator:
This is an initial attempt at implementing this in ScummVM. What I have so far:
I'm definitely going to need help with testing it, because it's easy to miss things. (I almost missed the keyboard shortcuts.)
Here is a preview of what I intend to use it for. In v6 and v7 games, the Edit menu is disabled. (In earlier games, it's not.) And in Maniac Mansion (which uses the same kind of Mac GUI), the Sound menu is also disabled.
I guess this also opens the door - just a crack - to keeping the menus active during dialogs. (In the original, this allows you to use the Edit menu during the Save dialog, though all other menus are grayed out.) But that appears to be quite tricky.