DIRECTOR: Fixes for D5 support #6420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moralrecordings
force-pushed
the
d5_features
branch
from
03afd6c to
9bdd93f
Compare
sev-
requested changes
Feb 3, 2025
|
|
||
| if (name.contains(" Bold") || name.equalsIgnoreCase("Bold")) |
There was a problem hiding this comment.
Why these " <slant>" checks were removed?
There was a problem hiding this comment.
The checks have been refactored (there was a typo where name was used instead of subName, which is now fixed). Real Director expects a comma-separated list of case-insensitive slant types, which are applied incrementally. So you could have shadow,italic,plain,underline,bold, which resolves to the same thing as underline,bold.
There was a problem hiding this comment.
The tokenizer should split the string by either " " or "," characters so there's no need to check for spaces
Fixes crashes when starting a new game in Zeddas: Servant of Sheol.
Previously, using unsigned integers made it possible to overflow the timeout check, as you can redefine the tick baseline (and therefore the last timeout figure) via Lingo. Fixes catching mice in The Great Green Mouse Disaster.
In D5, the castNum will return a multiplexed ID instead of just the member ID, and various other features will accept and use the multiplexed ID. Fixes the story playback and basic navigation in Smarty.
Fixes display of text cards in Murphy's TV.
Fixes the language icons on the remote control in Murphy's TV.
moralrecordings
force-pushed
the
d5_features
branch
from
b71cd50 to
4b801e7
Compare
Include new properties/aliases introduced in D5, fixes crashes related to incorrect casting to MacText.
moralrecordings
force-pushed
the
d5_features
branch
from
4b801e7 to
9012e44
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.