SCUMM: MACGUI: Disable Maniac Mansion Mac GUI while paused #6422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this by setting the _messageBannerActive flag. It's not really a banner, I guess, but close enough. Also simplified the check a bit. Back when it was just Loom and Indy 3, we checked if their custom banner window had been created. But the message banner flag actually covers that as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mac GUI for the SCUMM games does not work well when the game is paused. At least not the way pause/message banners are handled, so the Mac GUI is suppressed while there is one on screen.
When it was just Loom and Indy 3, we just checked if the custom message banner had been created. When other games were added, we also tested the
_messageBannerActiveflag. But this was not set for old style games, and now Maniac Mansion (which was ported to the Mac for the Day of the Tentacle Easter Egg) is in the process of being supported. So this pull request sets the_messageBannerActiveflag for that case as well. I hope this doesn't break anything, but there was no one around on Discord that I could ask.(It also turns out that this flag is already set for Loom and Indy 3, so we don't have to check for the custom message banner.)