PRIVATE: Take cursor images from Windows executable #6481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluegr
reviewed
Mar 13, 2025
|
Nice work! This removes all the hardcoded cursor data, and makes the code cleaner |
|
@ellm135 I've tried this locally, and it works great, nice work again! Do you have any further changes / improvements for this? If not, please change the state of the PR to "Ready for review", so that it can be merged |
bluegr
reviewed
Mar 15, 2025
bluegr
reviewed
Mar 15, 2025
Windows cursors have a reference to windows cursor groups, so the same resources were deleted twice
It's been marked as ready. Thank you! |
|
Thanks. Squashing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
