-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Czech translation for Kyrandia 1, 2, and 3. #6519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mbreskovec
commented
Mar 27, 2025
db69484
to
74fd5ea
Compare
Thanks! I have made some fixes and additions. And all three parts seem to work with the translation files that you linked. |
Thank you for you help @athrxx, I am able run all three games with activated translation now, however it looks like characters coding is not correct. I must find the way how to fix it. |
Thanks for testing! |
I prefer to fix it mow if possible. All three games are affected. Czech national characters in strings are wrong in kyra.dat resource files, game translation files are OK. When I am used convert.py all files were in UTF-8, maybe I need to convert characters to win1250/cp1250 or iso-8859-2 or IBM852/CP852 (Latin 2), I don't have idea which encoding should be the right one. |
Okay, UTF-8 is really unlikely to be correct. It is much more likely to be one of the "old" codepages from the DOS and early Windows era. The convert.py doesn't fix the encoding, it just converts the characters greater than 0x7f to hex numbers to avoid compiler warnings (we want the code .cpp and .h files to be plain ascii). So I guess it would be the best approach now to just test one or two kyradat strings with different encodings and see if it turns our correct. You needn't run convert.py for your testing, you just have to do that for your actual commit. But you have to run the create_kyradat tool to make a new kyra.dat to test your changes. And depending on the OS you're using, you might have to copy the resulting kyra.dat file into the dists\engine-data folder (at least for Windows and MacOS, the kyra.dat will be incorporated into the ScummVM executable and it will be picked up from that folder). |
Could you please give me an advice how to create kyra.dat? Where I will find the create_kyradat tool? |
The tool can be built with The code for the tool is located in /devtools/create_kyradat/ |
I am fixed texts in all three games, but I have some troubles with Kyra 1. There is several strings in the Main Menu options which are blank (their are blank even is I will use content from lok_dos_cd_english.h with only static char fields renaming from English to Czech). Another issue which I am found during the brief testing is that Note for Brinn is not readable. When Brandon is trying to read it it will not appear on the screen. Please see attached pictures. |
Thanks for your continued work on this. Could you please add the commit with your updated resource texts here? (not the regenerated KYRA.DAT, just the .h-files) I might then be able to finish it up... |
d3f5936
to
0bda819
Compare
Thanks for the updated text strings. I have made some fixes for the options strings and for Brynn's note. Please check if this works fine, now. |
It looks OK. I am pushed one typo fix. But I have question, Note for Brynn is in English, is there any way how to translate it? |
Short answer: No ;-) Longer answer: |
Thank you for explanation, in such case my work is done now. Thank you for your help again. |
7849643
to
295b1c4
Compare
Okay, I have updated kyra.dat to include your typo fix. |