Skip to content

Czech translation for Kyrandia 1, 2, and 3. #6519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 2, 2025

Conversation

mbreskovec
Copy link
Contributor

SUBSYSTEM: Adding Czech translation for Kyrandia 1, 2, and 3.

According to the [discussion](https://forums.scummvm.org/viewtopic.php?p=100481) with [athrxx](https://forums.scummvm.org/memberlist.php?mode=viewprofile&u=7992&sid=0ec109eb72b32088f39079a1e44bfe8d) I am prepared this pull request with added Czech fan translations for Kyrandia 1, 2, and 3.

Czech translation files can be downloaded from:

- Kyrandia 1 - https://lokalizace.net/cestina-do/the-legend-of-kyrandia-1992
- Kyrandia 2 - https://lokalizace.net/cestina-do/the-legend-of-kyrandia-the-hand-of-fate-1993
- Kyrandia 2 - https://lokalizace.net/cestina-do/the-legend-of-kyrandia-malcolms-revenge-1994

@athrxx athrxx force-pushed the kyrandia-czech-translation branch from db69484 to 74fd5ea Compare March 28, 2025 14:22
@athrxx
Copy link
Contributor

athrxx commented Mar 28, 2025

Thanks! I have made some fixes and additions. And all three parts seem to work with the translation files that you linked.
Please check if it works for you, too.

@mbreskovec
Copy link
Contributor Author

Thank you for you help @athrxx, I am able run all three games with activated translation now, however it looks like characters coding is not correct. I must find the way how to fix it.

@athrxx
Copy link
Contributor

athrxx commented Mar 28, 2025

Thanks for testing!
Should we merge this now and fix the encoding later?
Or do you want to have the encoding fixed first?
Is it the encoding of the kyra.dat strings or the encoding of the script strings or both that need fixing?
Do all three games have the exact same issue?

@mbreskovec
Copy link
Contributor Author

I prefer to fix it mow if possible. All three games are affected. Czech national characters in strings are wrong in kyra.dat resource files, game translation files are OK. When I am used convert.py all files were in UTF-8, maybe I need to convert characters to win1250/cp1250 or iso-8859-2 or IBM852/CP852 (Latin 2), I don't have idea which encoding should be the right one.

@athrxx
Copy link
Contributor

athrxx commented Mar 28, 2025

I prefer to fix it mow if possible. All three games are affected. Czech national characters in strings are wrong in kyra.dat resource files, game translation files are OK. When I am used convert.py all files were in UTF-8, maybe I need to convert characters to win1250/cp1250 or iso-8859-2 or IBM852/CP852 (Latin 2), I don't have idea which encoding should be the right one.

Okay, UTF-8 is really unlikely to be correct. It is much more likely to be one of the "old" codepages from the DOS and early Windows era.
The translation patches also seem to include a patched main.exe. The correctly encoded strings could probably be extracted from there.

The convert.py doesn't fix the encoding, it just converts the characters greater than 0x7f to hex numbers to avoid compiler warnings (we want the code .cpp and .h files to be plain ascii). So I guess it would be the best approach now to just test one or two kyradat strings with different encodings and see if it turns our correct. You needn't run convert.py for your testing, you just have to do that for your actual commit. But you have to run the create_kyradat tool to make a new kyra.dat to test your changes. And depending on the OS you're using, you might have to copy the resulting kyra.dat file into the dists\engine-data folder (at least for Windows and MacOS, the kyra.dat will be incorporated into the ScummVM executable and it will be picked up from that folder).

@mbreskovec
Copy link
Contributor Author

Could you please give me an advice how to create kyra.dat? Where I will find the create_kyradat tool?

@athrxx
Copy link
Contributor

athrxx commented Mar 29, 2025

The tool can be built with make devtools . This will also build a bunch of other tools, but create_kyradat is one of them.

The code for the tool is located in /devtools/create_kyradat/

@mbreskovec
Copy link
Contributor Author

I am fixed texts in all three games, but I have some troubles with Kyra 1. There is several strings in the Main Menu options which are blank (their are blank even is I will use content from lok_dos_cd_english.h with only static char fields renaming from English to Czech). Another issue which I am found during the brief testing is that Note for Brinn is not readable. When Brandon is trying to read it it will not appear on the screen. Please see attached pictures.

note-for-brinn
main-menu-game-settings
main-menu-exit-game

@athrxx
Copy link
Contributor

athrxx commented Apr 2, 2025

Thanks for your continued work on this. Could you please add the commit with your updated resource texts here? (not the regenerated KYRA.DAT, just the .h-files)

I might then be able to finish it up...

@athrxx athrxx force-pushed the kyrandia-czech-translation branch from d3f5936 to 0bda819 Compare April 2, 2025 16:51
@athrxx
Copy link
Contributor

athrxx commented Apr 2, 2025

Thanks for the updated text strings. I have made some fixes for the options strings and for Brynn's note. Please check if this works fine, now.

@mbreskovec
Copy link
Contributor Author

It looks OK. I am pushed one typo fix. But I have question, Note for Brynn is in English, is there any way how to translate it?

@athrxx
Copy link
Contributor

athrxx commented Apr 2, 2025

It looks OK. I am pushed one typo fix. But I have question, Note for Brynn is in English, is there any way how to translate it?

Short answer: No ;-)

Longer answer:
The CD version (which is used here as a base for the fan translation) has a bitmap image (NOTEENG.CPS for English, NOTEGER.CPS for German, NOTEFRE.CPS for French, all of these contained in MISC.PAK) which already has the text in it. This is unlike what some floppy versions do, which actually load an empty background image for the note and then print the text on top of that.
So, it really depends on whether the authors of the fan tranlations went the extra mile to also make modified versions of the bitmap files (it's really the same for TEXT_ENG.CPS and MAIN_ENG.CPS). In this case, this seems not to have happened.

@mbreskovec
Copy link
Contributor Author

Thank you for explanation, in such case my work is done now. Thank you for your help again.

@athrxx athrxx force-pushed the kyrandia-czech-translation branch from 7849643 to 295b1c4 Compare April 2, 2025 20:12
@athrxx
Copy link
Contributor

athrxx commented Apr 2, 2025

Okay, I have updated kyra.dat to include your typo fix.
Thanks for your work on this.
I'll merge this now...

@athrxx athrxx merged commit c93f01e into scummvm:master Apr 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants