Skip to content

DIRECTOR: Dump decompiled lingo script #6533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shanmukhaReddyK
Copy link
Contributor

@shanmukhaReddyK shanmukhaReddyK commented Apr 2, 2025

  • previously --dump-scripts command line option we were able to dump only .lscr (bytecode).

  • updated it functionality so that it can dump all decompiled scripts with .lingo extension along with bytecode

@shanmukhaReddyK shanmukhaReddyK changed the title Director : Dump decompiled lingo script DIRECTOR : Dump decompiled lingo script Apr 2, 2025
@shanmukhaReddyK shanmukhaReddyK changed the title DIRECTOR : Dump decompiled lingo script DIRECTOR: Dump decompiled lingo script Apr 2, 2025
Ensure lingo script is dumped only when --dump-lingo is specified.
Preventing unnecessary dumps when debugChannelSet(-1, kDebugImGui)
is satisfied
@sev- sev- added the GSoC Part of a Google Summer of Code project label Apr 2, 2025
@sev-
Copy link
Member

sev- commented Apr 2, 2025

Please change the commits and history to conform with our Commit Guidelines: https://wiki.scummvm.org/index.php?title=Commit_Guidelines

@shanmukhaReddyK
Copy link
Contributor Author

@sev- I have changed the commit messages and also the code format , if any other changes are required please inform me.

@sev-
Copy link
Member

sev- commented Apr 7, 2025

I tested your changes and they do not work as expected. The produced filenames are practically not possible to match with .lscr files

For example, generated file Main_eng.dxr-movie-65.lscr is correspondent to Main_eng.dxr-movie-65601.lingo and Shared.CXT-movie-28.lscr is Shared.CXT-movie-196636.lingo

Please review the logic related to the file name generation

@shanmukhaReddyK
Copy link
Contributor Author

@sev- can u provide the names of the movies which u tested?

@sev-
Copy link
Member

sev- commented Apr 8, 2025

@shanmukhaReddyK it does not matter. Run any demo for D4/D5 and dump its scripts. The filenames should always match for bytecode and decompiled files

@sev-
Copy link
Member

sev- commented Apr 19, 2025

Merged manually as is, since @shanmukhaReddyK clearly abandoned the task.

Will fix the problem in-tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Part of a Google Summer of Code project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants