IMAGE: Get palette class by reference on image decoders #6535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OMGPizzaGuy
force-pushed
the
image-decoder-palette-interface
branch
2 times, most recently
from
095831f to
d0c5b60
Compare
ccawley2011
reviewed
Apr 5, 2025
OMGPizzaGuy
force-pushed
the
image-decoder-palette-interface
branch
from
d0c5b60 to
c319d82
Compare
|
Great work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the use of palette class by altering the getPalette() method on ImageDecoder to return a const reference to the palette class. Image decoders without palettes return an empty palette. A few decoder instances now copy palette data rather than retain a pointer.
Thoughts: