-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
QDENGINE: Add support for rgba8888 pixel format #6552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would it be possible to make this configurable at run-time, so that it still works with more backends? |
Yes, I think is possible to do so. Then during engine initialization I should check if backend supports rgba8888 with with OSystem::getSupportedFormats(). If yes, then use that format, otherwise use rgb565 as before. Do you mean something like that? |
This change fixes draw_grid() method, where IMPASSIBLE_CELL_CLR was used for normal cells.
This change fixes bug when rgb565 is used. The code for RGBA8888 mode was already correct.
The I recommend adding a GUIO "run in 16bpp" and a debugflag "16bpp", so it is possible to switch it from the command line, and use it. Question, your shveik shadowing fix, will it also work for 565? |
Yes. In fact, it fixes the 565 version. 8888 was already working correctly from the first commit. |
Thank you! |
This PR attempts to bring rgba8888 pixel format to the engine. Changes have been made to every drawing function, except for putSprMask and putSprMask_rot methods. So far during playtesting I haven't seen these methods being called, so I put STUBs to them for the moment.