Skip to content

QDENGINE: Add support for rgba8888 pixel format #6552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 17, 2025

Conversation

ormanbai123
Copy link
Contributor

@ormanbai123 ormanbai123 commented Apr 11, 2025

This PR attempts to bring rgba8888 pixel format to the engine. Changes have been made to every drawing function, except for putSprMask and putSprMask_rot methods. So far during playtesting I haven't seen these methods being called, so I put STUBs to them for the moment.

@sev- sev- added the GSoC Part of a Google Summer of Code project label Apr 11, 2025
@ccawley2011
Copy link
Member

Would it be possible to make this configurable at run-time, so that it still works with more backends?

@ormanbai123
Copy link
Contributor Author

Would it be possible to make this configurable at run-time, so that it still works with more backends?

Yes, I think is possible to do so.

Then during engine initialization I should check if backend supports rgba8888 with with OSystem::getSupportedFormats(). If yes, then use that format, otherwise use rgb565 as before. Do you mean something like that?

@ormanbai123 ormanbai123 changed the title QDENGINE: Convert engine to rgba8888 pixel format QDENGINE: Add support for rgba8888 pixel format Apr 13, 2025
This change fixes bug when rgb565 is used. The code for RGBA8888 mode was
already correct.
@sev-
Copy link
Member

sev- commented Apr 15, 2025

The I recommend adding a GUIO "run in 16bpp" and a debugflag "16bpp", so it is possible to switch it from the command line, and use it.

Question, your shveik shadowing fix, will it also work for 565?

@ormanbai123
Copy link
Contributor Author

ormanbai123 commented Apr 15, 2025

Question, your shveik shadowing fix, will it also work for 565?

Yes. In fact, it fixes the 565 version. 8888 was already working correctly from the first commit.

@sev-
Copy link
Member

sev- commented Apr 17, 2025

Thank you!

@sev- sev- merged commit e263f77 into scummvm:master Apr 17, 2025
8 checks passed
@ormanbai123 ormanbai123 deleted the rgba8888 branch April 18, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Part of a Google Summer of Code project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants