-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
DIRECTOR: Fixes for Derrat Sorcerum #6555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This causes a regression in TKKG 1, Jennifer is missing. |
@shelloverride will you be able to bisect this to a specific commit? |
I can for sure try later ,hopefully every commit compiles and works on its own. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made my round of review
if i didn't make a mistake in my first bisect analysis is the one that remains after the process. |
d710daf
to
90ab926
Compare
Fixed the text entry widget in TKKG1. There's a bunch of broken animations still, but that's not a regression from this changeset. |
When determining what sprite the mouse is hovering over, this is a top-down search of all channels. For text widgets with scrollbars, in real Director the scrollbar is like a hole that bypasses the stage entirely. This is important when you have a mouseUp handler attached to a text cast member with scroll bars, and a mouseUp handler attached to the cast member directly behind it. Clicking the scroll bar should not invoke either handler, but should still invoke e.g. a mouseUp handler attached to the score frame. Fixes interaction with the inventory list in Derrat Sorcerum.
If there is an Xtra in the Xtras folder and an XObject DLL in the root path with the same name, the Xtra will have been preloaded and therefore take precedence. Fixes initial load scripts for Pothead.
Calling "go to frame N" in an input handler should not call the associated exitFrame handler. This is checked with the skipAdvanceFrame flag; however this can be cleared prematurely if an idle handler exists and Score::update() runs multiple times. Fixes mixing the True Sight potion in Derrat Sorcerum.
Director has an internal mapping of characters that are basically the same, which it uses for the string equality checks. Useful if, to pick a random example, you have one set of scripts which refer to "Erwin's Catalyst" and another set which refer to "Erwin’s Catalyst". Fixes using Erwin's Catalyst in Derrat Sorcerum.
Expanded the number of flags output by Datum::compareTo; equality isn't a guarantee that a greater-than-or-equal or less-than-or-equal comparison will also work.
Fixes glitch when clicking the inventory for the first time in Derrat Sorcerum.
Fixes name entry screen in tkkg1.
90ab926
to
1554f35
Compare
No the game was broken before, animations&gameplay, but that wasn't the reason for my comment. |
8643c19
to
faf9c72
Compare
Fixed for me when i build the branch this pr draws from on Linux. |
Thank you! |
No description provided.