POSIX: Follow XDG Base Directory Specification for User's Files #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordhoto
force-pushed
the
xdg-dirs-posix
branch
from
97b7ff1
to
4edc015
Compare
| if (prefix) { | ||
| path = prefix; | ||
| path += '/'; | ||
| path += dir; |
There was a problem hiding this comment.
Any catches for '../../../'? Or these should be fine?
There was a problem hiding this comment.
Works fine, mkdir uses the CWD as base if the path is not absolute.
|
In general, I had a good impression, and think that this could make it to 1.8.0 |
|
OK, please update the patch (now it has conflicts) and merge. |
added 2 commits
February 2, 2016 08:45
This is kind of like 'mkdir -p' now. But the permissions are different from standard POSIX behavior.
lordhoto
force-pushed
the
xdg-dirs-posix
branch
from
4edc015
to
5da7a1b
Compare
added 6 commits
February 2, 2016 09:16
This makes use use the XDG Base Directory Specification for the log file path. This tackles one part of bug #6036 "POSIX: Use XDG dirs instead of HOME".
…/scummvm.ini'. This is what the XDG Base Directory Specification suggests to use. We still use the old location of '~/.scummvmrc' in case that is present. This tackles an aspect of bug #6036 "POSIX: Use XDG dirs instead of HOME".
This is what the XDG Base Directory Specification suggests to use. We still use ~/.scummvm as default path in case the directory exists. This tackles an aspect of bug #6036 "POSIX: Use XDG dirs instead of HOME".
lordhoto
force-pushed
the
xdg-dirs-posix
branch
from
5da7a1b
to
7d014be
Compare
lordhoto
added a commit
that referenced
this pull request
Feb 2, 2016
POSIX: Follow XDG Base Directory Specification for User's Files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This patch makes our POSIX ports use locations for configuration, log, and save games conforming to the XDG Base Directory Specification version 0.8 (right now the latest version, which can be found here).
The new locations are as follows:
$XDG_CONFIG_HOME/scummvm/scummvm.ini$XDG_DATA_HOME/scummvm/saves/$XDG_CACHE_HOME/scummvm/scummvm.logWe still use the old locations for the configuration file and the savegame directory if those exist from a previous ScummVM installation.
This 'fixes' bug #6036 POSIX: Use XDG dirs instead of HOME. There is some discussion on the bug report about using a more easily visible location for save files. If we want that, we should do go for it now instead of having to worry about it again later.