VIDEO: QTVR: Remove bug in QTVR while changing nodes #6584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a bug in QTVR decoder where _upscaledConstructedPanorama doesn't stores the previous node (panorama) when you change the current node, unlike _constructedPano Reset the value of _upscaleLevel to 0 when constructing _constructedPano indicating that _upscaledConstructedPanorama holds invalid panorama and should be reupscaled while projecting in projectPanorama()
|
Thank you, this resolved the issue with the old node staying in view. |
|
Reopening, due to github webinterface being a bit weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous pull request (merged) #6548
implemented an upscaled panorama for projection in higher quality.
However, it also introduced a bug where if you change the node
(panorama), the
_constructedPanois now the node you changed tobut the
_upscaledConstructedPanois still on the previous nodeThis caused the
projectPanorama()function to project the wrong panorama whenin high quality mode.
Fix this bug by resetting the
_upscaleLevelto 0 when we're constructing_constructedPanowhich implies that we have toupscale the
_constructedPanoramafrom scratch duringprojectPanorama()So whenever the
_constructedPanois reconstructed, so will be_upscaledConstructedPano