Skip to content

CI: Save vcpkg cache even on build failure #6585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

orgads
Copy link
Contributor

@orgads orgads commented May 1, 2025

No description provided.

@orgads orgads requested a review from SupSuper May 1, 2025 16:33
@SupSuper
Copy link
Contributor

SupSuper commented May 2, 2025

Won't this save a broken cache if vcpkg fails? We don't have a way of separating vcpkg errors from build errors.

@orgads
Copy link
Contributor Author

orgads commented May 4, 2025

Won't this save a broken cache if vcpkg fails? We don't have a way of separating vcpkg errors from build errors.

Good point, fixed now.

@orgads orgads merged commit 380b8d5 into scummvm:master May 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants