Skip to content

ANDROID: Trigger an abort on error #6589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

ANDROID: Trigger an abort on error #6589

merged 1 commit into from
May 3, 2025

Conversation

lephilousophe
Copy link
Member

This also outputs a stacktrace in the system log and reports it to Google Play for further diagnostics.

I am not sure we really want this, hence I do a PR for it.

@lephilousophe
ANDROID: Trigger an abort on error
4fbb6d1 
This also outputs a stacktrace in the system log and reports it to
Google Play for further diagnostics.
@lephilousophe lephilousophe requested a review from antoniou79 May 2, 2025 21:43
antoniou79
antoniou79 approved these changes May 3, 2025
View reviewed changes
Copy link
Contributor

@antoniou79 antoniou79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this PR, we'll get more useful info to debug error cases.
The code looks fine to me, but I haven't had the time to actually build it and test it on a device, yet.
Still, I think it's ok to merge.

@bluegr
Copy link
Member

bluegr commented May 3, 2025

Thanks!

@bluegr bluegr merged commit fa741de into scummvm:master May 3, 2025
8 checks passed
@lephilousophe lephilousophe deleted the android-error-stacktrace branch May 3, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniou79 antoniou79 antoniou79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lephilousophe @bluegr @antoniou79