BACKENDS: Use DefaultPaletteManager for all backends #6595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you are going to do this, then why do you keep PaletteManager interface? BTW, did you check that every commit is compilable? |
|
I was thinking of suggesting actual use DefaultPaletteManager or removing it altogether. Either way this definitely aligns with my interests. |
|
@ccawley2011 any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having a common base class that manages the palette, it becomes easier to extend it with new features. It also ensures that all implementations follow the specified behaviour for
grabPalette()("This should return exactly the same RGB data as was setup via previous setPalette calls.").