JANITORIAL: Silence Compiler Warnings #6604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkuendig
force-pushed
the
fix-warnings
branch
2 times, most recently
from
ab5b7b7 to
05f3fbd
Compare
bluegr
reviewed
May 12, 2025
…aded virtual function"
bluegr
reviewed
May 15, 2025
|
Thanks! Note that JPEGDecoder is the only image decoder that exhibits this problem, as it inherits from both Codec and ImageDecoder. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some recently added compiler warnings ( I tried to git blame them to ensure I understood the code):
jpeg.h- I think introduced with 4c4a94c / IMAGE: Get palette class by reference on image decoders #6535archive.h- I think introduced with 7885931Edit: Looks like the "sdlGetAttribute" change isn't working on all platforms. I'll have another look at it.fixed