-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
TESTBED: Small Improvements & Bugfixes #6605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Please fix code formatting |
…an up formatting in fs.cpp
…ation issues in testbed.cpp
Sorry missed the formatting issues. Fixed now (and I also fixed some older formatting issues in the same files) |
Would it be possible to have this button in desktop builds too, which would open the log file with the default system text editor? |
I havent seen any comparable function to open files on the host system in OSystem or any specific backend. The reason I added this to Emscripten was because theres no good way to access the filesystem (intially needed for screenshots), but in theory this could work everywhere if we feel its worth implementing for each backend. Probably should be added as an optional feature to OSystem. PS: I wonder how the mobile platforms solve this, its not that easy to access the filesystem there either. |
We do have This function is implemented in some of our backends (including Emscripten). Perhaps we could override the log file name that is opened by this function? |
Make Interactive Mode configurable in GUI I wanted to be able to run testbed in automated mode without adjusting the scummvm.ini - this is now possible:

Fix file writing if game data directory is read-only: This is a bug we discussed a while ago on discord: https://discord.com/channels/581224060529148060/711242520415174666/1339720409745981582. If the game directory is read-only the write tests and the filelog are not stored in the savegame location.
Support opening logfile in Emscripten: This is similar to the screenshot export from Emscripten: Screenshot and Logfile support and minor bugfixes & improvements #5587. I added a button to download the log file:

Fix freeze when playing MIDI in Emscripten: This type of loop needs to yield to the browser regularly in single-threaded Emscripten.