Skip to content

TESTBED: Small Improvements & Bugfixes #6605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

chkuendig
Copy link
Member

@sev-
Copy link
Member

sev- commented May 9, 2025

Please fix code formatting

@chkuendig
Copy link
Member Author

Sorry missed the formatting issues. Fixed now (and I also fixed some older formatting issues in the same files)

@scummvm scummvm locked as spam and limited conversation to collaborators May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm deleted a comment May 10, 2025
@scummvm scummvm unlocked this conversation May 11, 2025
@bluegr
Copy link
Member

bluegr commented May 14, 2025

Support opening logfile in Emscripten: This is similar to the screenshot export from #5587. I added a button to download the log file:

Would it be possible to have this button in desktop builds too, which would open the log file with the default system text editor?

@chkuendig
Copy link
Member Author

chkuendig commented May 14, 2025

I havent seen any comparable function to open files on the host system in OSystem or any specific backend. The reason I added this to Emscripten was because theres no good way to access the filesystem (intially needed for screenshots), but in theory this could work everywhere if we feel its worth implementing for each backend. Probably should be added as an optional feature to OSystem.

PS: I wonder how the mobile platforms solve this, its not that easy to access the filesystem there either.

@bluegr
Copy link
Member

bluegr commented May 17, 2025

I havent seen any comparable function to open files on the host system in OSystem or any specific backend. The reason I added this to Emscripten was because theres no good way to access the filesystem (intially needed for screenshots), but in theory this could work everywhere if we feel its worth implementing for each backend. Probably should be added as an optional feature to OSystem.

PS: I wonder how the mobile platforms solve this, its not that easy to access the filesystem there either.

We do have displayLogFile(), a function called to open our default log file in the system's default text editor.

This function is implemented in some of our backends (including Emscripten).

Perhaps we could override the log file name that is opened by this function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants