DIRECTOR: Fixes for transitions and sprite updates #6648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transitions can run over almost any time frame. This creates an issue when xStepSize and yStepSize are used as increments; they are ints which strip out fractions of a pixel, and the error will be compounded by the number of steps. This is visible as e.g. sweep transitions stopping at the 3/4 mark. An option would be to change xStepSize and yStepSize into floats, but instead we do the cheaper calculation of premultiplying xStepSize and yStepSize by TSTEP_FRAC to give 10 bits of precision.
It's possible for a developer to make an exitFrame handler that checks for a condition (e.g. rollOver), then changes a sprite member without setting the puppet flag, then calls updateStage(). The result is the new graphic shows up while the condition is true, then reverts back to whatever was in the frame when the condition goes false. Fixes the cooked main menu screen in kidsbiblepaul. Fixes the menu system in kyoto.
Needed for 77365ba to work properly. Fixes palette regressions in The Seven Colors.
moralrecordings
force-pushed
the
d5_features
branch
from
493712c to
3f2985a
Compare
Fixes clickable hotspots in tkkg1.
Fixes wrongly-repeating animations in tkkg1.
Real Director doesn't seem to care about surrounding whitespace characters. Fixes savegame parsing in Cracking the Conspiracy.
The original XObj version of FileIO will dispose of the object if m_delete is called. The Xtra version does not. Fixes savegame handler in Cracking the Conspiracy.
Window::loadNextMovie will get called if you create a new Window with Lingo and then set it to visible. In this case, you don't want to call setCurrentWindow; if you do, the current script will keep running but in the context of the new Window, which collapses pretty quickly. The main loop will call DirectorEngine::setCurrentWindow when appropriate, so it's unlikely we need this. Fixes opening the PDA in Cracking the Conspiracy.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.