Skip to content

ENGINES: Replace glColor3*/glColorPointer calls with OpenGL ES compatible calls #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2025

Conversation

ccawley2011
Copy link
Member

This is split out from PR #4633, and expanded to cover engines other than Stark.

@ccawley2011 ccawley2011 changed the title ENGINES: Replace glColor3* calls with OpenGL ES compatible calls ENGINES: Replace glColor3*/glColorPointer calls with OpenGL ES compatible calls May 29, 2025
Copy link
Member

@lephilousophe lephilousophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that you should not mess with tglColor3* calls.
Except from that and my other comment, LGTM.

@ccawley2011
Copy link
Member Author

I would say that you should not mess with tglColor3* calls. Except from that and my other comment, LGTM.

I'd prefer to keep the OpenGL and TinyGL renderers as close as possible for things like this, but I can drop the TinyGL changes if you'd prefer.

@lephilousophe
Copy link
Member

I have no strong opinion on this.

@aquadran
Copy link
Member

aquadran commented Jun 1, 2025

I would say that you should not mess with tglColor3* calls. Except from that and my other comment, LGTM.

I'd prefer to keep the OpenGL and TinyGL renderers as close as possible for things like this, but I can drop the TinyGL changes if you'd prefer.

I think keep them in aligned. that what I do in 3d engines

@lephilousophe
Copy link
Member

Merging, then.

@lephilousophe lephilousophe merged commit 94f7e36 into scummvm:master Jun 1, 2025
8 checks passed
@ccawley2011 ccawley2011 deleted the opengl-color4f branch June 1, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants