BASE: Show error description when game fails to run #6666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous "not...any engine" message was appropriate in the past (circa 1a93895), but with changes over time it began appearing even for other error conditions (e.g. some game data files missing); thus it was sometimes incorrect.
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous "not...any engine" message was appropriate in the past (circa 1a93895), but with changes over time it began appearing even for other error conditions (e.g. some game data files missing); thus it is sometimes incorrect.
Instead, show a message like we already do around line 824.
When I first tried this, I saw a lot of "Unknown error", hence #6665 :-)
Wretched PR number ✞
By the way, if this isn't an acceptable change, shall we consider adjusting the translated string to be the same as the almost identical one currently near gui/launcher.cpp:562, "ScummVM could not find any engine capable of running the selected game!"? (But I think we should change it: if game files are missing, it isn't right to say there is no capable engine.)