Skip to content

MADE: Split up the music player class to support other platforms #6681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

ccawley2011
Copy link
Member

Macintosh music hasn't been implemented yet, but it should be relatively simple to reuse the Halestorm driver from the Kyra engine.

@bluegr
Copy link
Member

bluegr commented Jun 2, 2025

Is the Mac version music format supported by the Halestorm driver? I was under the impression that all versions use the same music format

@ccawley2011
Copy link
Member Author

There's some discussion on the subject on Discord: https://discord.com/channels/581224060529148060/711242520415174666/1379133782518665279

@bluegr
Copy link
Member

bluegr commented Jun 9, 2025

The Mac version doesn't even start at the moment. It seems to have either endianess issues, or differences in opcodes.

This is a step towards the right direction, so once we manage to get the Mac version working, we can check for the music format and music playing.

Thanks! Merging

@bluegr bluegr merged commit 56ff3ac into scummvm:master Jun 9, 2025
8 checks passed
@ccawley2011 ccawley2011 deleted the made-music-split branch June 9, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants