-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
SLUDGE: Add keymapper support #6693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
engines/sludge/keymapper_tables.h
Outdated
act = new Action(kStandardActionPause, _("Pause")); | ||
act->setKeyEvent(KeyState(KEYCODE_ESCAPE, ASCII_ESCAPE)); | ||
act->addDefaultInputMapping("ESCAPE"); | ||
act->addDefaultInputMapping("JOY_START"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JOY_START
and JOY_BACK
are reserved for the Global Main Menu and Virtual Keyboard respectively, so should be avoided in game-specific keymaps.
engines/sludge/keymapper_tables.h
Outdated
act = new Action("SHOWFLOOR", _("DEBUG: Show floor")); | ||
act->setKeyEvent(KeyState(KEYCODE_f, 'f')); | ||
act->addDefaultInputMapping("f"); | ||
act->addDefaultInputMapping("JOY_RIGHT"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be necessary to add default joystick bindings for debug actions.
engines/sludge/keymapper_tables.h
Outdated
|
||
Keymap *gameKeyMap = new Keymap(Keymap::kKeymapTypeGame, gameId, gameDescr); | ||
Keymap *debugKeyMap = new Keymap(Keymap::kKeymapTypeGame, "debug", _("Debug keymap")); | ||
Keymap *controllerKeymap = new Keymap(Keymap::kKeymapTypeGame, "controller", _("Controller keymap for menus")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you clarify what "controller" means in this context?
engines/sludge/keymapper_tables.h
Outdated
act->addDefaultInputMapping("JOY_X"); | ||
gameKeyMap->addAction(act); | ||
|
||
} else if (gameId == "tgttpoacs") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a minigame located in the Arcade called "Wizard Warble" that uses some additional keys that aren't currently listed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to press Enter to start the minigame where you look for the contact lens in the changing rooms.
1994781
to
fee2422
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be rebased. Please pay attention, that we added verbcoin2 as a new target
engines/sludge/POTFILES
Outdated
@@ -0,0 +1,2 @@ | |||
engines/sludge/detection_tables.h | |||
engines/sludge/keymapper_tables.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline
fee2422
to
4d5d82e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one small wish.
|
||
} else { | ||
// Default keymap for other games | ||
act = new Action(kStandardActionLeftClick, _("Left Click")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add here something like
warning("Game-specific keymap is not defined. Using default SLUDGE engine keymap");
4d5d82e
to
00b5425
Compare
Thank you! |
No description provided.