Skip to content

WINTERMUTE: Reduce direct access to surface pixel buffers #6696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

WINTERMUTE: Reduce direct access to surface pixel buffers #6696

merged 1 commit into from
Jun 12, 2025

Conversation

ccawley2011
Copy link
Member

No description provided.

aquadran
aquadran requested changes Jun 6, 2025
View reviewed changes
Copy link
Member

@aquadran aquadran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at this point I don't want unnecessary changes, which may lead to regressions

@ccawley2011
Copy link
Member Author

at this point I don't want unnecessary changes, which may lead to regressions

If it helps, I can revert the g_system->fillScreen change and the change to the RenderTicket constructor, and address the extra surface that the latter change addresses in a later PR. The rest of the changes should be safe.

@aquadran
Copy link
Member

at this point I don't want unnecessary changes, which may lead to regressions

If it helps, I can revert the g_system->fillScreen change and the change to the RenderTicket constructor, and address the extra surface that the latter change addresses in a later PR. The rest of the changes should be safe.

lets wait a bit, after finished retesting, we can merge it and check briefly few games for regression

@aquadran aquadran merged commit 051ff0e into scummvm:master Jun 12, 2025
8 checks passed
@ccawley2011 ccawley2011 deleted the wintermute-getbaseptr branch June 15, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquadran aquadran aquadran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccawley2011 @aquadran