Conversation
|
Ok I found there have been commits to this engine not done by me. How can I update my fork to the current version whilst retaining my commits to resolve the conflicts? Normally I would do a merge, but as I understand from last PR this is not accepted, since it shows up in the changelog. |
|
Indeed. Just do a rebase and not a merge. There will be a few conflicts to be resolved on that way. |
|
Done, conflicts have been resolved. |
|
These are great news. I was wondering about it. For announcing engine testing, we have a procedure described here: https://wiki.scummvm.org/index.php?title=HOWTO-Engine_Release Could you please drop by the Discord, and we can discuss how I can help. The more thorough code review will follow. |
|
I added the GUIO docs. Also enabled build-by-default, and added the new games in the NEWS.md Credits update is still ongoing as I am awaiting some feedback for inclusion. |
| @@ -1,3 +1,3 @@ | |||
| # This file is included from the main "configure" script | |||
| # add_engine [name] [desc] [build-by-default] [subengines] [base games] [deps] [components] | |||
| add_engine alg "American Laser Games" no | |||
There was a problem hiding this comment.
This needs to be reverted for this PR
|
Thank you. I'll disable the engine in the meantime until the announcement is posted. |
ALG Engine:
Now all games should be completeable, I managed to play through each game at least once.
All missing functionality for Last Bounty Hunter was implemented, making it supported and also completeable.
Quite a few bugs have been found and fixed, but I am sure some are still well-hidden.
Therefore I would like to request a review of the code changes as well as ask for testers.