Merged
Conversation
iOS and tvOS shares much of the same code. Normally all differences between the targets are handled in the backend where Xcode specific pre-processor macros can be used to distinguish the platforms. In shared code, even if it's still Apple specific, we need a define to separate the iOS and tvOS targets. Add such and use it in the shared CoreMIDI code. This fixes buildbot issues.
The CoreMIDI framework was missed when building the iOS7 port using configure. Add it.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't use CoreMIDI in tvOS ports and make sure CoreMIDI framework is added to the iOS7 port when using configure.