NANCY: Fix TurningPuzzle solve animation timing#7277
Merged
bluegr merged 1 commit intoscummvm:masterfrom Mar 2, 2026
Merged
Conversation
Remove the division by _currentOrder.size() for the frame delay calculation. It depends only on _solveDelayBetweenTurns and _numFramesPerTurn. Remove the initial _nextTurnTime calculation so the animation always starts without delay. Both behaviors follow the original game.
Member
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the division by _currentOrder.size() for the frame delay calculation. It depends only on _solveDelayBetweenTurns and _numFramesPerTurn.
Remove the initial _nextTurnTime calculation so the animation always starts without delay.
Both behaviors follow the original game.
see https://bugs.scummvm.org/ticket/15946 for comparison videos to the original game.