AGOS: Simon1 Acorn - Fix playback of mods for the full version of Simon 1 Acorn Floppy.#7282
Merged
bluegr merged 1 commit intoscummvm:masterfrom Mar 2, 2026
Merged
Conversation
…on 1 Acorn Floppy.
Member
|
Nice work, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Acorn Desktop Tracker module playback for Simon 1 Acorn floppy where only some tunes would play.
The previous pull request was only tested against the demo, however I'm now the owner of an original copy of the full floppy version.
The Desktop Tracker player assumed the pattern offset table always started after the sequence table. That works for mods like 7TUNE but other modules use different padding, so the parser would read the pattern offsets from the wrong place.
The change makes the parser robust by detecting the table instead of assuming it.
Tested several scenes and the playback works fine.