DM: Replace raw thing-data casts with typed struct arrays#7594
Merged
Conversation
mohitbankar
force-pushed
the
DM
branch
2 times, most recently
from
3d24a12 to
de25dc3
Compare
mohitbankar
changed the title
mohitbankar
force-pushed
the
DM
branch
2 times, most recently
from
6e12f50 to
0df0152
Compare
Thing data was previously accessed via pointer casts on raw uint16 arrays. Each type is now parsed into its own typed Common::Array<T> at load time.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thing data (doors, weapons, armour, etc.) was previously stored as raw uint16 arrays and accessed via pointer casts (e.g. (Weapon *)getThingData(thing)), relying on assumptions about struct layout that don't hold on all platforms.
Each thing type is now parsed into its own Common::Array at load time, and accessed via typed accessors (getWeapon(), getDoor(), etc.) replacing the old casts.