Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maemo Port revival #78

Closed
wants to merge 33 commits into from
Closed

Conversation

tsoliman
Copy link
Member

This isn't fully featured yet as the original maemo port. I've only really tested the N810 (keyboard + touchscreen + no openGL)

The intention of this pull request is to get feedback on what could be done better and hopefully merge it into master.
#86 is kept identical and rebased for merging

} else if (ev.key.keysym.sym == SDLK_F8) {
_clickEnabled = !_clickEnabled;
((SurfaceSdlGraphicsManager*) _graphicsManager)->displayMessageOnOSD(
_clickEnabled ? "Clicking Enabled" : "Clicking Disabled");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make these translatable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed (I think)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, also edit po/POFILES

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sev-
Copy link
Member

sev- commented Aug 27, 2011

I'd say this looks like a proper backend, and not a hack. Pretty close to inclusion.

@tsoliman
Copy link
Member Author

I'd say this looks like a proper backend, and not a hack. Pretty close to inclusion.

sev, please don't merge this before I rebase it. I want to squish some of the commits together without affecting the review process so I'll probably open a new pull request when you give me the go-ahead.

@tsoliman
Copy link
Member Author

I've created a branch maemo-master-rebased-2 where I cleaned up history (it is a nul diff with the current branch).

@tsoliman
Copy link
Member Author

TODO still based on the current feedback:

  • Figure out the icon situation The icon is a base64 encoded png image that's 26x26
  • Create README info for developers (how to build, etc) Added in a comment below. Should go on the wiki.
  • Create README info for users (what the keymappings are) is this supposed to go on the wiki? Added in a comment below. Should go on the wiki.
  • Figure out what debian/postinst is doing and add comments in it
  • Test out -O2 instead of the current -Os Nevermind, Android uses it.

@tsoliman
Copy link
Member Author

tsoliman commented Sep 4, 2011

I am not sure I should put those READMEs in the tree. I think they should go on the wiki.
Here are the contents of what I want to put on the wiki (If I may have access I would edit the wiki directly)

@tsoliman
Copy link
Member Author

tsoliman commented Sep 4, 2011

User README

Keymappings

Menu: Bring up the scummvm menu (in-game)
Fullscreen: Toggle fullscreen/windowed mode
Zoom+: Right-click
Zoom-: Switch clicking mode
CTRL + Zoom-: Activate virtual keyboard

Developer README

How to compile

Compiling has to be done on a linux machine running debian/ubuntu.
On non-linux machines, a linux virtual machine running debian/ubuntu can be used.

STEP1: Download and install the maemo-sdk package

Add the following line to /etc/apt/sources.list

deb http://maemo-sdk.garage.maemo.org/download/host debian-squeeze free

STEP2: Create symlink from backends/platform/maemo/debian to the root of the scummvm checkout

ln -s backends/platform/maemo/debian

STEP3a: Build the deb package

sb2 dpkg-buildpackage -b

STEP3b: compile without building a deb package

sb2 ./configure --host=maemo
sb2 make

@tsoliman
Copy link
Member Author

sev-: I think I have addressed most of (all?) your concerns.
Let me know what else is to be done before this is ready to be merged.
(Don't merge it when it is ready, instead merge branch maemo-master-rebased-2)

@tsoliman
Copy link
Member Author

I created #86 and linked both of them to each other.
Pull request 86 is supposed to the one merged and this one should be closed without merging.

@bluegr
Copy link
Member

bluegr commented Sep 23, 2011

Closing this one, as requested.
New version is at #86

@bluegr bluegr closed this Sep 23, 2011
BenCastricum pushed a commit to BenCastricum/scummvm that referenced this pull request Dec 30, 2021
In commit a78d311 ("Clean up message logic and eof handling")
the eof character was being checked in readData. When master mode
however, this led to an unbound eof variable as loop condiational.

Fixes scummvm#78

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants