-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maemo Port revival #78
Conversation
kyra has a file that won't compile in -Os
The giant configure line is now shortened to the following configure --host=maemo
Instead of explicitly passing everything, use the new host=maemo configure capabilities
| } else if (ev.key.keysym.sym == SDLK_F8) { | ||
| _clickEnabled = !_clickEnabled; | ||
| ((SurfaceSdlGraphicsManager*) _graphicsManager)->displayMessageOnOSD( | ||
| _clickEnabled ? "Clicking Enabled" : "Clicking Disabled"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make these translatable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed (I think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, also edit po/POFILES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
I'd say this looks like a proper backend, and not a hack. Pretty close to inclusion. |
I also modified the history to reflect that I am now the maintainer
sev, please don't merge this before I rebase it. I want to squish some of the commits together without affecting the review process so I'll probably open a new pull request when you give me the go-ahead. |
This reverts commit 8a6aaaeac540bba2733697abfc46f91e82adf3b3.
|
I've created a branch maemo-master-rebased-2 where I cleaned up history (it is a nul diff with the current branch). |
|
TODO still based on the current feedback:
|
This wouldn't be needed if this was done by default
|
I am not sure I should put those READMEs in the tree. I think they should go on the wiki. |
User READMEKeymappingsMenu: Bring up the scummvm menu (in-game) Developer READMEHow to compileCompiling has to be done on a linux machine running debian/ubuntu. STEP1: Download and install the maemo-sdk packageAdd the following line to /etc/apt/sources.list STEP2: Create symlink from backends/platform/maemo/debian to the root of the scummvm checkoutSTEP3a: Build the deb packageSTEP3b: compile without building a deb package |
|
sev-: I think I have addressed most of (all?) your concerns. |
|
I created #86 and linked both of them to each other. |
|
Closing this one, as requested. |
In commit a78d311 ("Clean up message logic and eof handling") the eof character was being checked in readData. When master mode however, this led to an unbound eof variable as loop condiational. Fixes scummvm#78 Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
This isn't fully featured yet as the original maemo port. I've only really tested the N810 (keyboard + touchscreen + no openGL)
The intention of this pull request is to get feedback on what could be done better
and hopefully merge it into master.#86 is kept identical and rebased for merging