SCI32: Implement kRobot #805
Conversation
|
Wow. Just wow. |
|
@sev-, yeah, that is a very familiar emotion, having spent like a month on this one feature, peeling away layer after layer of amazing design decisions. :) |
| @@ -31,6 +31,7 @@ namespace Sci { | |||
|
|
|||
| enum ScaleSignals32 { | |||
| kScaleSignalNone = 0, | |||
| // TODO: rename to 'manual' | |||
There was a problem hiding this comment.
Does that refer to kScaleSignalNone?
|
Excellent work, for a very weirdly designed functionality :) I had done progress on this myself, but then I read on IRC that you were working on this too, so, since my free time is very limited these days, I did not progress afterwards. Overall, this looks good, however it's merged into one gigantic commit, which makes it quite hard to follow. Could you please split this up into smaller commits? |
|
Usually I'm all in favour of smaller commits, but since practically all of this commit is adding new, related functionality and I don't quite see which parts could be split up, one single commit makes sense to me here. |
|
Amazing work on this. It's gone through several debugging passes already, and I think this can be be merged as-is. |
|
What is the status of V4 Robot videos? IIRC, these were only used in the SWAT demo... which used to work fine with the previous code. Does that still work? There are a lot of V4-related TODOs. Furthermore, for completeness sake, can a comment be added mentioning which games use V4, V5 and V6 robot files? I believe that it goes like this:
IIRC, Lighthouse does not use Robot videos, right? Can the list above be double checked, and added as a comment? Finally, I'd like a reply to my comment above (about kScaleSignalNone). |
|
Sorry, Lighthouse does use robot videos. Thus, if I'm not mistaken, the list above is:
|
|
Landed at 0f2748b. |
|
And what about my questions and request above? |
Not much else to say about this one. Makes a bunch of stuff work. Many many thanks to @wjp for helping figure out the craziest details of the audio format.