Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
WINTERMUTE: Add detection for current Steam release of reversion1 #890
I tried to add the Linux versions of reversion1 today. The games are detected, but the only version that starts is the Spanish one. I have to figure out why, I did the same as I did with the Windows versions. Maybe language selection via Common::XY_XYZ is broken for non-Windows wintermute?
Therefore I suggest to merge this PR at it's current state in order to fix #9679. We can always open a new PR if I can sort out the Linux issues.
What do you think?
@RootFather there was a lot of past discussion on this ticket. When you get a chance can you just recap what is still outstanding here that needs to be addressed? It looked like there was a naming issue and a language detection issue and it’s unclear to me from the discussion what was the final outcome/decision.
@csnover I haven't worked on this patch for quite some time, so I have to somewhat figure out again what's going on.
One thing we have to handle with is that WME_ENTRY1s cannot be used because it won't detect the other languages and we have to use WME_ENTRY2s twice to detect the spanish version.
And yes, there's still a naming issue, but I think that can simple be reverted to the state it was before this PR.