Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSDL: fix options control tab ordering and labels #912
Merged
Conversation
- control options tab is moved past graphics options tab - control tab is not the default anymore - changed label of "Mouse Speed" option to "Pointer Speed" - changed Pointer Speed infotip description to make it more clear
gui/options.cpp
Outdated
| @@ -244,7 +245,7 @@ void OptionsDialog::build() { | |||
| int value = ConfMan.getInt("kbdmouse_speed", _domain); | |||
| if (_kbdMouseSpeedSlider && value < sizeof(kbdMouseSpeedLabels)) { | |||
This comment has been minimized.
This comment has been minimized.
wjp
Feb 27, 2017
Member
This shouldn't be sizeof, but ARRAYSIZE(kbdMouseSpeedLabels). Or maybe - 1 to avoid the 0 terminator. You should probably also check if value >= 0.
This comment has been minimized.
This comment has been minimized.
Closed
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rsn8887 commentedFeb 26, 2017
•
edited