Join GitHub today
GRAPHICS: Consider flip mode when handling off-screen clipping #979
Hi, I meet a bug concerning transparent surface when importing the sludge engine, which is, when a horizontally flipped sprite leaves the scene from the left side, it begins to disappear from the right side. So I guess maybe we need to take the flip mode in to account when handling off-screen clipping in transparent_surface.cpp and it works for Sludge games.
Thanks for addressing this with a PR.
I believe, all things considered, this can be the appropriate place to add this behaviour.
My brain is not the most sound of static analyzers, but at a glance the changes appear reasonable (as in, correct) to me.
At a glance I don't see an obvious performance cost either. Good.
transparent_surface.his used in sword25, wintermute, fullpipe, wage and director.
Wintermute seems unaffected by the change, ie. it doesn't apparently break anything in there. Also good.
flippingseems to be used exclusively in
I don't have a copy to test if it works in there. @sev- appears to be the main author of
fullpipeand one of the largest contributors to
sword25along with @bluegr, so I'd ask them if this matches the semantics they have/had in mind just to be sure. Skimming the code in
engines/fullpipeI don't see any obvious inconsistencies.
@csnover and the SCI gang might also be interested in these changes.