From 72780fcbecd7ddbfbd4a01ced57ad70f07d9ea26 Mon Sep 17 00:00:00 2001 From: Philipp A Date: Fri, 26 Jan 2024 13:35:12 +0100 Subject: [PATCH] Fix for _validate_palette for old numpy versions, prepare 1.9.8 hotfix release (#2832) --- docs/release-notes/1.9.8.md | 3 ++- scanpy/plotting/_utils.py | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/release-notes/1.9.8.md b/docs/release-notes/1.9.8.md index 6551d06ccb..4c954a878c 100644 --- a/docs/release-notes/1.9.8.md +++ b/docs/release-notes/1.9.8.md @@ -1,4 +1,5 @@ -### 1.9.8 {small}`the future` +### 1.9.8 {small}`2024-01-26` ```{rubric} Bug fixes ``` +- Fix handling of numpy array palettes for old numpy versions {pr}`2832` {smaller}`P Angerer` diff --git a/scanpy/plotting/_utils.py b/scanpy/plotting/_utils.py index 2edf6f618e..94e10327f6 100644 --- a/scanpy/plotting/_utils.py +++ b/scanpy/plotting/_utils.py @@ -380,8 +380,8 @@ def _validate_palette(adata: AnnData, key: str) -> None: _palette = None break _palette.append(color) - # Don't modify if nothing changed - if _palette is None or np.equal(_palette, adata.uns[color_key]).all(): + # Don’t modify if nothing changed + if _palette is None or np.array_equal(_palette, adata.uns[color_key]): return adata.uns[color_key] = _palette