Skip to content

fix: scipy==1.18.0rc1 warnings#4144

Merged
ilan-gold merged 2 commits into
mainfrom
ig/scipy_rc_18_warnings
Jun 5, 2026
Merged

fix: scipy==1.18.0rc1 warnings#4144
ilan-gold merged 2 commits into
mainfrom
ig/scipy_rc_18_warnings

Conversation

@ilan-gold

Copy link
Copy Markdown
Contributor
  • Closes #
  • Tests included or not required because:

@ilan-gold ilan-gold added this to the 1.12.2 milestone Jun 5, 2026
@ilan-gold ilan-gold marked this pull request as ready for review June 5, 2026 15:26
@ilan-gold ilan-gold enabled auto-merge (squash) June 5, 2026 15:26
@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.61%. Comparing base (4ba31e4) to head (258bef4).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4144   +/-   ##
=======================================
  Coverage   79.61%   79.61%           
=======================================
  Files         120      120           
  Lines       12786    12786           
=======================================
  Hits        10179    10179           
  Misses       2607     2607           
Flag Coverage Δ
hatch-test.low-vers 78.85% <100.00%> (ø)
hatch-test.pre 79.45% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scanpy/readwrite.py 81.27% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ilan-gold ilan-gold merged commit d66537f into main Jun 5, 2026
14 checks passed
@ilan-gold ilan-gold deleted the ig/scipy_rc_18_warnings branch June 5, 2026 15:54
@lumberbot-app

lumberbot-app Bot commented Jun 5, 2026

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.12.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 d66537fba529a11d390be3b5fe2e3f851a27d09b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #4144: fix: `scipy==1.18.0rc1` warnings'
  1. Push to a named branch:
git push YOURFORK 1.12.x:auto-backport-of-pr-4144-on-1.12.x
  1. Create a PR against branch 1.12.x, I would have named this PR:

"Backport PR #4144 on branch 1.12.x (fix: scipy==1.18.0rc1 warnings)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant