Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved cmap handling for images #194

Merged
merged 4 commits into from
Dec 8, 2023
Merged

improved cmap handling for images #194

merged 4 commits into from
Dec 8, 2023

Conversation

Sonja-Stockhaus
Copy link
Collaborator

Includes the bugfix from @aeisenbarth's #188 with some further adjustments regarding the case when only one cmap is provided by the user but the image has multiple channels

@Sonja-Stockhaus Sonja-Stockhaus marked this pull request as ready for review December 8, 2023 12:43
@codecov-commenter
Copy link

Codecov Report

Merging #194 (dedc344) into main (74afb01) will increase coverage by 0.25%.
Report is 9 commits behind head on main.
The diff coverage is 92.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   77.94%   78.20%   +0.25%     
==========================================
  Files          11       11              
  Lines        1297     1312      +15     
==========================================
+ Hits         1011     1026      +15     
  Misses        286      286              
Files Coverage Δ
src/spatialdata_plot/pl/basic.py 87.37% <ø> (-0.07%) ⬇️
src/spatialdata_plot/pl/utils.py 63.18% <100.00%> (+0.66%) ⬆️
src/spatialdata_plot/pl/render.py 88.58% <88.88%> (-0.27%) ⬇️

@timtreis timtreis merged commit b82e7f5 into main Dec 8, 2023
6 checks passed
@timtreis timtreis deleted the bugfix/pr188_colormaps branch December 8, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants