From 5200e0295d89a47a2ce51fffcab838b50f2eecf1 Mon Sep 17 00:00:00 2001 From: Luca Marconato Date: Wed, 22 Oct 2025 17:16:52 +0200 Subject: [PATCH 1/2] fix table_name --- src/spatialdata_plot/pl/utils.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/spatialdata_plot/pl/utils.py b/src/spatialdata_plot/pl/utils.py index 9ef5bcfd..5428d05b 100644 --- a/src/spatialdata_plot/pl/utils.py +++ b/src/spatialdata_plot/pl/utils.py @@ -852,9 +852,8 @@ def _set_color_source_vec( color_source_vector = pd.Categorical(color_source_vector) # convert, e.g., `pd.Series` - # TODO check why table_name is not passed here. color_mapping = _get_categorical_color_mapping( - adata=sdata["table"], + adata=sdata[table_name], cluster_key=value_to_plot, color_source_vector=color_source_vector, cmap_params=cmap_params, From b2817ea3052ac8396897ae6a07fcd1b6acafece2 Mon Sep 17 00:00:00 2001 From: Luca Marconato Date: Thu, 23 Oct 2025 22:40:33 +0200 Subject: [PATCH 2/2] fix tests; fix typing for coloring column --- src/spatialdata_plot/pl/utils.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/spatialdata_plot/pl/utils.py b/src/spatialdata_plot/pl/utils.py index 5428d05b..cf21d212 100644 --- a/src/spatialdata_plot/pl/utils.py +++ b/src/spatialdata_plot/pl/utils.py @@ -853,7 +853,7 @@ def _set_color_source_vec( color_source_vector = pd.Categorical(color_source_vector) # convert, e.g., `pd.Series` color_mapping = _get_categorical_color_mapping( - adata=sdata[table_name], + adata=sdata.get(table_name, None), cluster_key=value_to_plot, color_source_vector=color_source_vector, cmap_params=cmap_params, @@ -946,7 +946,7 @@ def _map_color_seg( def _generate_base_categorial_color_mapping( - adata: AnnData, + adata: AnnData | None, cluster_key: str, color_source_vector: ArrayLike | pd.Series[CategoricalDtype], na_color: Color, @@ -1020,7 +1020,7 @@ def _get_default_categorial_color_mapping( def _get_categorical_color_mapping( - adata: AnnData, + adata: AnnData | None, na_color: Color, cluster_key: str | None = None, color_source_vector: ArrayLike | pd.Series[CategoricalDtype] | None = None,