Upgrade NUnit to 4.4.0 #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/upgrade-nunit-to-4
branch
3 times, most recently
from
7f10b38 to
c2c0e01
Compare
dkropachev
force-pushed
the
dk/upgrade-nunit-to-4
branch
from
c2c0e01 to
2f59e46
Compare
wprzytula
reviewed
Sep 17, 2025
wprzytula
left a comment
wprzytula
left a comment
There was a problem hiding this comment.
❓ What's the very goal of the upgrade?
src/Cassandra.IntegrationTests/Cassandra.IntegrationTests.csproj
Outdated
Show resolved
Hide resolved
dkropachev
force-pushed
the
dk/upgrade-nunit-to-4
branch
from
2f59e46 to
319f503
Compare
dkropachev
force-pushed
the
dk/upgrade-nunit-to-4
branch
from
319f503 to
9938185
Compare
dkropachev
commented
Sep 17, 2025
| { | ||
| Assert.Fail("Awaited Task without ConfigureAwait() call in file {0}: {1}", | ||
| fileInfo.FullName, match.Value); | ||
| Assert.Fail($"Awaited Task without ConfigureAwait() call in file {fileInfo.FullName}: {match.Value}"); |
Collaborator
Author
There was a problem hiding this comment.
Just in case, this one is needed, since Assert.Fail( is a bit different in NUnit.Framework.Legacy.ClassicAssert
Collaborator
Author
To keep this dependancy updated. |
wprzytula
approved these changes
Sep 18, 2025
NUnit 4 has different Assert API. So, some test code changes needed.
dkropachev
force-pushed
the
dk/upgrade-nunit-to-4
branch
from
9938185 to
7f06807
Compare
1 task
wprzytula
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NUnit 4 has different Assert API.
So, some test code changes needed.