Add parsing TABLETS_ROUTING_V1 extension #21
Conversation
sylwiaszunejko
force-pushed
the
tablet_routing_v1
branch
from
d407975 to
ab7cd59
Compare
src/Cassandra.IntegrationTests/TestBase/TestCassandraVersion.cs
Outdated
Show resolved
Hide resolved
| if (options.TabletsRoutingV1) | ||
| { | ||
| startupOptions.Add(StartupOptionsFactory.TabletsRoutingV1Option, "true"); | ||
| } | ||
|
|
There was a problem hiding this comment.
What will happend if you set this option all the time ?
I think it should work just fine
There was a problem hiding this comment.
this option is needed so the server know that it should send the tablet info, if the driver does not support using tablets the server won't send the tablets info, tablets metadata is quite expensive to generate, so an old driver (without support for tablets) will generate huge amounts of such notifications.
There was a problem hiding this comment.
|
@dkropachev do you think this need some tests? |
sylwiaszunejko
force-pushed
the
tablet_routing_v1
branch
from
ab7cd59 to
cc1ff2a
Compare
In order for Scylla to send the tablet info, the driver must tell the database during connection handshake that it is able to interpret it.
sylwiaszunejko
force-pushed
the
tablet_routing_v1
branch
from
cc1ff2a to
feb2e55
Compare
Nope, let's have a task on that, my understanding that #20 needs to be addressed first and only then we can have a test that works properly on all the versions. |
2 participants
In order for Scylla to send the tablet info, the driver must tell
the database during connection handshake that it is able to
interpret it.
Fixes: #11