Tablets are not updated for every type of query except select

[dkropachev]

Currently code that updates tablets on response:

java-driver/core/src/main/java/com/datastax/oss/driver/internal/core/cql/CqlRequestHandler.java

Lines 476 to 487 in e5cb7d6

	if (resultSet.getColumnDefinitions().size() > 0
	&& resultSet
	.getExecutionInfo()
	.getIncomingPayload()
	.containsKey(TabletInfo.TABLETS_ROUTING_V1_CUSTOM_PAYLOAD_KEY)) {
	context
	.getMetadataManager()
	.addTabletFromPayload(
	resultSet.getColumnDefinitions().get(0).getKeyspace(),
	resultSet.getColumnDefinitions().get(0).getTable(),
	resultSet.getExecutionInfo().getIncomingPayload());
	}

Which requires resultSet.getColumnDefinitions().size() > 0 for tablets to be updated and only select queries have that.
As result, only SELECT queries are getting tablets updated on session.

[Lorak-mmk]

Do we know why this check was introduced? There probably was some reason. I'd guess that the author wanted to check something different and that was an indirect way of doing it.

[Bouncheck]

IIRC this was supposed to be a sure way to get table information, but it does seem to be a bug. For other statements with bound values the column definitions should be pulled from corresponding prepared statement and not the result set.

[dkropachev]

Do we know why this check was introduced? There probably was some reason. I'd guess that the author wanted to check something different and that was an indirect way of doing it.

Author wanted to get table and keyspace information, which they thought is available only at resultSet.getColumnDefinitions(), which is not true.