Potential duplicate randomized ports in integration tests on branch 3.x

[avelanarius]

As observed in a run (logs below), sometimes integration tests can randomize the same port for two different services:

ccm updateconf start_rpc:false native_shard_aware_transport_port:38127 rpc_port:34049 prometheus_port:39563 storage_port:45119 api_port:38459 native_transport_port:45119  --config-dir=/tmp/1631703414221-0

which causes integration tests to fail, as they timeout. (In this case, CQL server failed to start on port 45119)

ccm-logs-scylla-4.3.6 (2).zip
logs_30.zip

[avelanarius]

TODO: As we are running on "older" releases of Scylla, CQL server failing to start did not print a nice error message (scylladb/scylladb#9306). Check if the fix to scylladb/scylladb#9306 fixed this variant of this problem.

[avelanarius]

The ports are randomized here:

java-driver/driver-core/src/test/java/com/datastax/driver/core/CCMBridge.java

Lines 1261 to 1289 in d4eca65

	private Set<String> randomizePorts(Set<String> set) {
	Set<String> randomized = new LinkedHashSet<String>();
	for (String value : set) {
	randomized.add(randomizePorts(value));
	}
	return randomized;
	}
	private Map<String, Object> randomizePorts(Map<String, Object> map) {
	Map<String, Object> randomized = new HashMap<String, Object>();
	for (Map.Entry<String, Object> entry : map.entrySet()) {
	Object value = entry.getValue();
	if (value instanceof CharSequence) {
	value = randomizePorts((CharSequence) value);
	}
	randomized.put(entry.getKey(), value);
	}
	return randomized;
	}
	private String randomizePorts(CharSequence str) {
	Matcher matcher = RANDOM_PORT_PATTERN.matcher(str);
	StringBuffer sb = new StringBuffer();
	while (matcher.find()) {
	matcher.appendReplacement(sb, Integer.toString(TestUtils.findAvailablePort()));
	}
	matcher.appendTail(sb);
	return sb.toString();
	}