Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send perf emails also for the first job run #7495

Closed
soyacz opened this issue May 28, 2024 · 3 comments
Closed

Send perf emails also for the first job run #7495

soyacz opened this issue May 28, 2024 · 3 comments
Assignees

Comments

@soyacz
Copy link
Contributor

soyacz commented May 28, 2024

After creating a new job for perf test, the first successful run does not send email because there's no reference results (based on jenkins job path).
It's very inconvenient, as still there are valid results - just without comparison to previous run.

In that case, we should skip comparison and send email with N/A values instead of failing sending email.

@fruch
Copy link
Contributor

fruch commented Jul 9, 2024

@soyacz isn't the change I'm doing with pinning the jobs to compare with gonna help with this ?

i.e. only left case is when it's the first run of a completely fresh case

@soyacz
Copy link
Contributor Author

soyacz commented Jul 9, 2024

@soyacz isn't the change I'm doing with pinning the jobs to compare with gonna help with this ?

i.e. only left case is when it's the first run of a completely fresh case

Yes, the change will help with this one (assuming we have a default one to compare)

@fruch
Copy link
Contributor

fruch commented Jul 15, 2024

We agreed we don't need, and we are o.k. with having at least two run to get results on new jobs

@fruch fruch closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants