Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where are the help strings? #841

Closed
glommer opened this issue Mar 2, 2020 · 2 comments
Closed

Where are the help strings? #841

glommer opened this issue Mar 2, 2020 · 2 comments

Comments

@glommer
Copy link
Contributor

@glommer glommer commented Mar 2, 2020

A while ago, I had added help strings to most of our dashboards.

In particular, things that are confusing and non-obvious like "foreground writes". As the graphs moved to other dashboards, the annotations are no longer, and the i corner is gone.

Please revert them back from older versions, these help strings are important.

Also please have the discipline of adding help strings to any dashboard that is added. We shouldn't have a single graph without a help string.

@glommer

This comment has been minimized.

Copy link
Contributor Author

@glommer glommer commented Mar 4, 2020

See this commit: 310bcfc

The foreground and background queues, for instance, all had tooltips. Now that they were moved to a different dashboard, they no longer have.

Looking at the tooltip text I wrote before will save you time, but the gist of this bug is: every graph, in every dashboard should have a tooltip.

@amnonh

This comment has been minimized.

Copy link
Contributor

@amnonh amnonh commented Mar 5, 2020

@glommer
I found it already (that's why I deleted the comment) and sent a PR #842 ...

@amnonh amnonh closed this in #842 Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.