Navigation Menu

Skip to content

Commit

Permalink
dist/docker: fix errors in README.md
Browse files Browse the repository at this point in the history
The (oddly-placed) document dist/docker/debian/README.md explains how a
developer can build a Scylla docker image using a self-built Scylla
executable.

While the document begins by saying that you can "build your own
Scylla in whatever build mode you prefer, e.g., dev.", the rest of the
instructions don't fit this example mode "dev" - the second command does
"ninja dist-deb" which builds *all* modes, while the third command
forgets to pass the mode at all (and therefore defaults to "release").
The forth command doesn't work at all, and became irrelevant during
a recent rewrite in commit e96ff3d.

This patch modifies the document to fix those problems.

It ends with an example of how to run the resulting docker image
(this is usually the purpose of building a docker image - to run it
and test it). I did this example using podman because I couldn't get
it to work in docker. Later we can hopefully add the corresponding
docker example.

Fixes #9263.

Signed-off-by: Nadav Har'El <nyh@scylladb.com>
Message-Id: <20210829182608.355748-1-nyh@scylladb.com>
  • Loading branch information
nyh authored and penberg committed Aug 30, 2021
1 parent ed7106e commit d7474dd
Showing 1 changed file with 13 additions and 3 deletions.
16 changes: 13 additions & 3 deletions dist/docker/debian/README.md
Expand Up @@ -9,8 +9,18 @@ Do the following in the top-level Scylla source directory:

1. Build your own Scylla in whatever build mode you prefer, e.g., dev.

2. Run `ninja dist-deb`
2. Run `ninja dist-dev` (with the same mode name as above) to prepare
the distribution artifacts.

3. Run `/dist/docker/debian/build_docker.sh`
3. Run `./dist/docker/debian/build_docker.sh --mode dev`

This creates a docker image as a **file**, in the OCI format, and prints
its name, looking something like:
`oci-archive:build/dev/dist/docker/scylla-4.6.dev-0.20210829.4009d8b06`

4. Finally, run `docker build -t <image-name> .`
4. This file can copied to a docker repository, or run directly with podman:

`podman run oci-archive:build/dev/dist/docker/scylla-4.6.dev-0.20210829.4009d8b06`

Often with additional parameters, as in docs/alternator/getting-started.md:
`podman run --name scylla -d -p 8000:8000 oci-archive:... --alternator-port=8000 --alternator-write-isolation=always`

0 comments on commit d7474dd

Please sign in to comment.