Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resharding compactions not shown anywhere #2671

Closed
glommer opened this issue Aug 4, 2017 · 1 comment
Closed

resharding compactions not shown anywhere #2671

glommer opened this issue Aug 4, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@glommer
Copy link
Contributor

glommer commented Aug 4, 2017

Happens in 2.0 -> regression.

When resharding starts, the compactions it triggers are not visible in grafana. This happens because resharding is bypassing the compaction manager, which is where the resharding statistics come from.

@slivne
Copy link
Contributor

slivne commented Aug 13, 2017

@raphaelsc - did we move the resharding compactions under compaction manager ?

@slivne slivne added this to the 2.0 milestone Aug 13, 2017
penberg pushed a commit that referenced this issue Nov 7, 2017
Two reasons for this change:
1) every compaction should be multiplexed to manager which in turn
will make decision when to schedule. improvements on it will
immediately benefit every existing compaction type.
2) active tasks metric will now track ongoing reshard jobs.

Fixes #2671.

Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>
Message-Id: <20170817224334.6402-1-raphaelsc@scylladb.com>
(cherry picked from commit 10eaa23)
Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>
Message-Id: <20171103012758.19428-1-raphaelsc@scylladb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants