New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sstable CompressionInfo in scylla 2.2 identifies all compressors using qualified names #3546

Closed
elcallio opened this Issue Jun 25, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@elcallio
Contributor

elcallio commented Jun 25, 2018

Older scylla (and origin) names all "known" (i.e. in org.cassandra... namespace) compressors using unqualified names. Worse, older scylla does not accept qualified names here at all, making reading compressed data when downgrading impossible.

Should preserve old behaviour.

avikivity added a commit that referenced this issue Jun 26, 2018

sstables::compress: Ensure unqualified compressor name if possible
Fixes #3546

Both older origin and scylla writes "known" compressor names (i.e. those
in origin namespace) unqualified (i.e. LZ4Compressor).

This behaviour was not preserved in the virtualization change. But
probably should be.

Message-Id: <20180625124459.20041-1-calle@scylladb.com>

avikivity added a commit that referenced this issue Jun 27, 2018

sstables::compress: Ensure unqualified compressor name if possible
Fixes #3546

Both older origin and scylla writes "known" compressor names (i.e. those
in origin namespace) unqualified (i.e. LZ4Compressor).

This behaviour was not preserved in the virtualization change. But
probably should be.

Message-Id: <20180627110930.1619-1-calle@scylladb.com>
(cherry picked from commit 054514a)

avikivity added a commit that referenced this issue Jun 27, 2018

sstables::compress: Ensure unqualified compressor name if possible
Fixes #3546

Both older origin and scylla writes "known" compressor names (i.e. those
in origin namespace) unqualified (i.e. LZ4Compressor).

This behaviour was not preserved in the virtualization change. But
probably should be.

Message-Id: <20180627110930.1619-1-calle@scylladb.com>
(cherry picked from commit 054514a)

avikivity added a commit that referenced this issue Jun 28, 2018

sstables::compress: Ensure unqualified compressor name if possible
Fixes #3546

Both older origin and scylla writes "known" compressor names (i.e. those
in origin namespace) unqualified (i.e. LZ4Compressor).

This behaviour was not preserved in the virtualization change. But
probably should be.

Message-Id: <20180627110930.1619-1-calle@scylladb.com>
(cherry picked from commit 054514a)

argenet added a commit to argenet/scylla that referenced this issue Jul 6, 2018

sstables::compress: Ensure unqualified compressor name if possible
Fixes scylladb#3546

Both older origin and scylla writes "known" compressor names (i.e. those
in origin namespace) unqualified (i.e. LZ4Compressor).

This behaviour was not preserved in the virtualization change. But
probably should be.

Message-Id: <20180627110930.1619-1-calle@scylladb.com>
@tzach

This comment has been minimized.

Contributor

tzach commented Oct 25, 2018

@elcallio what is the user impact of this issue? error messages? operation fails? Thanks

@elcallio

This comment has been minimized.

Contributor

elcallio commented Oct 29, 2018

Impact is that iff downgrading from unpatched version, any sstables written by it will be unparsable -> open failures ("could not read sstable") + data loss.

@elcallio

This comment has been minimized.

Contributor

elcallio commented Oct 29, 2018

Note that this is only if downgrading from unpatched 2.2 to earlier. Moving forward is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment