New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static row size is not accounter for corretly during digest only query #3753

Closed
gleb-cloudius opened this Issue Sep 6, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@gleb-cloudius
Contributor

gleb-cloudius commented Sep 6, 2018

Installation details
Scylla version (or git commit hash): 8dea1b3

digest only query (only digest is returned, no data) does not account for static row size correctly. This may cause discrepancy between data query digest and digest only query and cause unnecessary read repair.

avikivity added a commit that referenced this issue Sep 6, 2018

mutation_partition: correctly measure static row size when doing dige…
…st calculation

The code uses incorrect output stream in case only digest is requested
and thus getting incorrect data size. Failing to correctly account
for static row size while calculating digest may cause digest mismatch
between digest and data query.

Fixes #3753.

Message-Id: <20180905131219.GD2326@scylladb.com>
(cherry picked from commit 9809235)

avikivity added a commit that referenced this issue Sep 6, 2018

mutation_partition: correctly measure static row size when doing dige…
…st calculation

The code uses incorrect output stream in case only digest is requested
and thus getting incorrect data size. Failing to correctly account
for static row size while calculating digest may cause digest mismatch
between digest and data query.

Fixes #3753.

Message-Id: <20180905131219.GD2326@scylladb.com>
(cherry picked from commit 9809235)

avikivity added a commit that referenced this issue Sep 6, 2018

mutation_partition: correctly measure static row size when doing dige…
…st calculation

The code uses incorrect output stream in case only digest is requested
and thus getting incorrect data size. Failing to correctly account
for static row size while calculating digest may cause digest mismatch
between digest and data query.

Fixes #3753.

Message-Id: <20180905131219.GD2326@scylladb.com>
(cherry picked from commit 9809235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment