New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only digest and data+digest queries have a discrepancy in result size calculation #3755

Closed
gleb-cloudius opened this Issue Sep 6, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@gleb-cloudius
Contributor

gleb-cloudius commented Sep 6, 2018

Installation details
Scylla version (or git commit hash): 9809235

Due to discrepancy in result size calculation only digest and data+digest queries may stop at different
page boundaries and have digest mismatch which will cause unneeded read repairs.

avikivity added a commit that referenced this issue Sep 8, 2018

mutation_partition: accurately account for result size in digest only…
… queries

When measuring_output_stream is used to calculate result's element size
it incorrectly takes into account not only serialized element size, but
a placeholder that ser::qr_partition__rows/qr_partition__static_row__cells
constructors puts in the beginning. Fix it by taking starting point in a
stream before element serialization and subtracting it afterwords.

Fixes #3755

Message-Id: <20180906153609.GJ2326@scylladb.com>
(cherry picked from commit d767428)

avikivity added a commit that referenced this issue Sep 8, 2018

mutation_partition: accurately account for result size in digest only…
… queries

When measuring_output_stream is used to calculate result's element size
it incorrectly takes into account not only serialized element size, but
a placeholder that ser::qr_partition__rows/qr_partition__static_row__cells
constructors puts in the beginning. Fix it by taking starting point in a
stream before element serialization and subtracting it afterwords.

Fixes #3755

Message-Id: <20180906153609.GJ2326@scylladb.com>
(cherry picked from commit d767428)

avikivity added a commit that referenced this issue Sep 8, 2018

mutation_partition: accurately account for result size in digest only…
… queries

When measuring_output_stream is used to calculate result's element size
it incorrectly takes into account not only serialized element size, but
a placeholder that ser::qr_partition__rows/qr_partition__static_row__cells
constructors puts in the beginning. Fix it by taking starting point in a
stream before element serialization and subtracting it afterwords.

Fixes #3755

Message-Id: <20180906153609.GJ2326@scylladb.com>
(cherry picked from commit d767428)

tgrabiec added a commit that referenced this issue Sep 12, 2018

mutation_partition: accurately account for result size in digest only…
… queries

When measuring_output_stream is used to calculate result's element size
it incorrectly takes into account not only serialized element size, but
a placeholder that ser::qr_partition__rows/qr_partition__static_row__cells
constructors puts in the beginning. Fix it by taking starting point in a
stream before element serialization and subtracting it afterwords.

Fixes #3755

Message-Id: <20180906153609.GJ2326@scylladb.com>
(cherry picked from commit d767428)

avikivity added a commit that referenced this issue Oct 7, 2018

mutation_partition: accurately account for result size in digest only…
… queries

When measuring_output_stream is used to calculate result's element size
it incorrectly takes into account not only serialized element size, but
a placeholder that ser::qr_partition__rows/qr_partition__static_row__cells
constructors puts in the beginning. Fix it by taking starting point in a
stream before element serialization and subtracting it afterwords.

Fixes #3755

Message-Id: <20180906153609.GJ2326@scylladb.com>
(cherry picked from commit d767428)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment